Simplify the TxPayload trait a little #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
approved these changes
Aug 26, 2022
|
Yeah; I realised that the call and pallet name were only ever used in validation so wanted to make it clear that they didn't need implementing/werent used otherwise :) (one advantage just that it's then more obvious that you can just impl |
lexnv
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most custom implementations will not do static validation, and for these, there's no need to require that a pallet and call name can be handed back. This tweak to the trait signature makes that clear.
I also exposed a way to create a
SubmittableExtrinsicwithout going through the previous steps, in case somebody has bytes for a pre-signed extrinsic that they'd like to submit.In response to #637 (though I think their issue is unrelated, it'll help with this sort of thing)